Remove the AccessControl class.
#680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
dkotter,
jeffpaul and
a team
as code owners
dkotter
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The PR removes the
AccessControlclass, which was responsible for handling the user access to features. Previously, we adopted a provider-first approach, with multiple features falling under it. To manage user access at the feature level, we introduced theAccessControlclass. However, with the refactoring of the plugin to a feature-first approach, user access is now handled within theFeatureclass, making the AccessControl class obsolete.Closes #669
How to test the Change
Test overall role/user permissions for the features.
Changelog Entry
Credits
Props @dkotter @iamdharmesh
Checklist: