Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Subscriber from the list of allowed roles #690

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 5, 2024

Description of the Change

As detailed in #645, we currently show Subscriber in our list of Allowed roles when seeing up role-based access for all of our Features. Since this role can't do anything with content, there's no real reason to show it, so this PR removes that.

Closes #645

How to test the Change

Go to any Feature and ensure Subscriber no longer shows in the Allowed roles list

Changelog Entry

Changed - Remove Subscriber for the allowed roles list.

Credits

Props @dkotter, @ankitguptaindia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 3.0.0 milestone Feb 5, 2024
@dkotter dkotter self-assigned this Feb 5, 2024
@dkotter dkotter requested review from jeffpaul and a team as code owners February 5, 2024 04:01
@dkotter dkotter requested review from Sidsector9 and removed request for a team and jeffpaul February 5, 2024 04:01
@dkotter dkotter merged commit 3be8d28 into develop Feb 9, 2024
12 checks passed
@dkotter dkotter deleted the fix/645 branch February 9, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Subscriber' Role Included in 'Allowed Roles' List Despite Lack of Capabilities
2 participants