Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Enable role-based access" and "Enable user-based access" settings options from the feature settings and set to be enabled by default. #692

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As described in #691, PR removes the "Enable role-based access" and "Enable user-based access" options and sets them to be enabled by default, aiming to eliminate confusion among users.

Before After
image image

Closes #691

How to test the Change

  1. Go to ClassifAI feature settings.
  2. Select roles in the allowed roles to provide access to that feature.
  3. Verify that only the selected roles have access to that feature.
  4. Select the user in the allowed users to provide access to that feature.
  5. Verify that the selected user has access to that feature.
  6. Enable user-based opt-out for the feature.
  7. Go to the user profile and verify that you see the checkbox for that feature to opt out of using it.
  8. Check the opt-out checkbox and save.
  9. Verify that access to that feature has been disabled.
  10. Uncheck the opt-out checkbox to opt back in to the feature.
  11. Verify that the user now has access to that feature.
  12. Follow these steps for each ClassifAI feature.

Changelog Entry

Removed - "Enable role-based access" and "Enable user-based access" settings options have been removed from the feature settings and set to be enabled by default.

Credits

Props @jeffpaul @dkotter @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested review from dkotter, jeffpaul and a team as code owners February 5, 2024 12:16
@iamdharmesh iamdharmesh added this to the 3.0.0 milestone Feb 5, 2024
@iamdharmesh iamdharmesh self-assigned this Feb 5, 2024
@dkotter dkotter merged commit ed7f9ac into develop Feb 5, 2024
12 checks passed
@dkotter dkotter deleted the enhancement/691 branch February 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants