Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE fixes for the Text to Speech controls #695

Merged
merged 1 commit into from
Feb 6, 2024
Merged

FE fixes for the Text to Speech controls #695

merged 1 commit into from
Feb 6, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 5, 2024

Description of the Change

In #666, it was reported that the play icon wasn't showing in Safari for the Text to Speech FE controls. I tested and was able to reproduce but I found additional issues. The audio block wasn't rendering in any browser for user's that weren't logged in (which is a newly introduced issue out of #611) and the icon wasn't showing for me in any browser if I wasn't logged in.

This PR fixes both of those issues by ensuring the block is rendered even if we don't have a logged in user and ensuring the dashicon font is loaded with our custom CSS.

Closes #666

How to test the Change

  1. Turn on the Text to Speech feature
  2. Ensure a piece of content has speech generated
  3. View that content on the front-end and ensure the audio block is showing for both logged-in and non-logged in users
  4. Ensure the play and pause icons are showing in Safari and other browsers

Changelog Entry

Fixed - Load the dashicon font when the Text to Speech block is used to ensure icons display.
Fixed - Ensure the Text to Speech block is rendered for non-logged in users.

Credits

Props @dkotter, @QAharshalkadu

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

…dashicon font is loaded so the play and pause buttons render
@dkotter dkotter added this to the 3.0.0 milestone Feb 5, 2024
@dkotter dkotter self-assigned this Feb 5, 2024
@dkotter dkotter requested review from jeffpaul and a team as code owners February 5, 2024 23:28
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 5, 2024
@dkotter dkotter requested review from iamdharmesh and removed request for a team and jeffpaul February 5, 2024 23:28
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @dkotter.

LGTM 🚀

@iamdharmesh iamdharmesh merged commit 7fa4155 into develop Feb 6, 2024
14 checks passed
@iamdharmesh iamdharmesh deleted the fix/666 branch February 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE (Safari browser) > Listen to this post button icon, which is not shown properly.
2 participants