Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the excerpt length setting saves properly #767

Merged
merged 1 commit into from
May 29, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented May 10, 2024

Description of the Change

While testing something else, noticed that when updating the Excerpt length setting for the Excerpt Generation Feature, the value I set never saved and always reverted to the default.

Looking into it, found that we were relying on the existing setting value and only using the new value if the existing didn't exist (which I think it will always exist). This conditional needed flipped around.

I worried this may be an issue in other places but in doing a spot check, didn't see this same problem anywhere else.

How to test the Change

Try changing the Excerpt length setting in the Excerpt Generation Feature and ensure the value saves

Changelog Entry

Fixed - Ensure the Excerpt length setting for the Excerpt Generation Feature can be changed.

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 3.1.0 milestone May 10, 2024
@dkotter dkotter self-assigned this May 10, 2024
@dkotter dkotter requested review from jeffpaul and a team as code owners May 10, 2024 21:57
@github-actions github-actions bot added the needs:code-review This requires code review. label May 10, 2024
@jeffpaul jeffpaul requested review from iamdharmesh and removed request for jeffpaul and a team May 13, 2024 16:32
@jeffpaul jeffpaul mentioned this pull request May 28, 2024
22 tasks
@Sidsector9 Sidsector9 merged commit 1179e74 into develop May 29, 2024
15 checks passed
@Sidsector9 Sidsector9 deleted the fix/excerpt-length branch May 29, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants