Ensure the excerpt length setting saves properly #767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
While testing something else, noticed that when updating the
Excerpt length
setting for the Excerpt Generation Feature, the value I set never saved and always reverted to the default.Looking into it, found that we were relying on the existing setting value and only using the new value if the existing didn't exist (which I think it will always exist). This conditional needed flipped around.
I worried this may be an issue in other places but in doing a spot check, didn't see this same problem anywhere else.
How to test the Change
Try changing the
Excerpt length
setting in the Excerpt Generation Feature and ensure the value savesChangelog Entry
Credits
Props @dkotter
Checklist: