-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/759: Add background processing for Embeddings Classification #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but overall this looks really good and seems to work well.
One other thing we'll need to do before this is ready to merge is bring these same changes over to the Azure OpenAI Embeddings Provider, as right now we only added this to the OpenAI Embeddings Provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and tests well but still need to account for this piece:
bring these same changes over to the Azure OpenAI Embeddings Provider
@Sidsector9 Let me know if you'd like me to tackle that
@dkotter sorry for the delay, I couldn't find time to pick this up. I'll work on Azure and revert soon for review. |
Description of the Change
This PR implements Action Scheduler to perform Embeddings Classification with 20 terms per job. (The count is opinionated, open to change it).
Closes #759
How to test the Change
/wp-admin/tools.php?page=classifai&tab=language_processing
wp_termmeta
table.Changelog Entry
Credits
Props @dkotter @Sidsector9
Checklist: