-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upkeep/scripts: Reorganize JS #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Sidsector9, This is great. The code looks good. However, I noticed 2 minor CSS things and added notes for the same could you please help look into it? Once it is resolved we would be good to merge this.
Thank you.
|
||
wp_enqueue_style( | ||
'classifai-language-processing-style', | ||
CLASSIFAI_PLUGIN_URL . 'dist/language-processing.css', | ||
[], | ||
get_asset_info( 'language-processing', 'version' ), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
wp_enqueue_style( | ||
'classifai-language-processing-style', | ||
CLASSIFAI_PLUGIN_URL . 'dist/language-processing.css', | ||
[], | ||
get_asset_info( 'language-processing', 'version' ), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @iamdharmesh, I've resolved the CSS issues in 00376be |
Description of the Change
Currently the asset files don't have a structure that makes it easy to search or develop functionality.
This PR moves the assets under
src/js/features
directory.Previously, we have Classification and TTS features inside the same file, and it was done because the settings for both had to be rendered inside the Document Panel.
This PR exposes the
<ClassifaiEditorSettingPanel />
component on the globalwindow
object which can be used b y both internal and 3rd-party developers to extend the Panel area to add more components.How to test the Change
Ensure the E2E tests pass.
Changelog Entry
Credits
Props @Sidsector9
Checklist: