Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/87 #90

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Hotfix/87 #90

merged 2 commits into from
Jul 24, 2019

Conversation

dustinrue
Copy link
Contributor

@dustinrue dustinrue commented Jun 19, 2019 •
edited
Loading

Description of the Change

For issue #87 I changed Classifai to ClassifAI. I also changed a comment in config.php.

Alternate Designs

Benefits

Consistency

Possible Drawbacks

N/A

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#87

@jeffpaul jeffpaul added this to the 1.4.0 milestone Jun 20, 2019
@jeffpaul jeffpaul added type:bug Something isn't working. needs:documentation This requires documentation. labels Jun 20, 2019
@jeffpaul jeffpaul self-requested a review June 20, 2019 21:59
jeffpaul
jeffpaul approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dustinrue, this looks good to me!

@jeffpaul jeffpaul modified the milestones: 1.4.0, 1.3.2 Jul 19, 2019
@helen helen merged commit 0ee8640 into 10up:develop Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

@dustinrue dustinrue

Labels
needs:documentation This requires documentation. type:bug Something isn't working.
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dustinrue @jeffpaul @helen