Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/setup cypress for e2e testing #106

Merged
merged 16 commits into from
Jun 20, 2023

Conversation

barneyjeffries
Copy link
Contributor

@barneyjeffries barneyjeffries commented Mar 14, 2023

Description of the Change

This PR adds Cypress for e2e testing, configured and with 2 tests set-up:

  1. block.test - the test creates a new classic post with dummy content, opens the post and checks content has been converted to blocks
  2. admin.test - the test logs in and deactivates and activates the plugin

Closes #65

How to test the Change

  1. Pull changes
  2. Run npm install
  3. Build assets: npm run build
  4. Start local environment: npm run env:start
  5. Open Cypress for testing: npm run cypress:open
  6. Use Cypress GUI to run tests and verify they are working

Changelog Entry

Added - e2e testing with Cypress

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@barneyjeffries
Copy link
Contributor Author

@cadic I seem to be having the same issue I had with this PR - the tests are failing. I tried bumping the WP version.

Would you mind reviewing and letting me know what you think the issue might be?

@barneyjeffries barneyjeffries marked this pull request as ready for review March 14, 2023 13:44
@barneyjeffries barneyjeffries requested review from jeffpaul, a team and dsawardekar as code owners March 14, 2023 13:44
@jeffpaul jeffpaul added this to the 1.2.0 milestone Mar 14, 2023
@jeffpaul jeffpaul removed the request for review from a team March 14, 2023 14:01
@jeffpaul jeffpaul removed the request for review from cadic April 7, 2023 14:31
@jeffpaul
Copy link
Member

jeffpaul commented May 8, 2023

@iamdharmesh note this is waiting your review

@jeffpaul jeffpaul requested a review from a team June 8, 2023 12:58
@jeffpaul
Copy link
Member

jeffpaul commented Jun 8, 2023

@10up/open-source-practice Cypress e2e PR up for review

@jeffpaul jeffpaul modified the milestones: 1.2.0, 1.2.1 Jun 8, 2023
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barneyjeffries,

Thanks a lot for the Great work here, the code looks good to me.

I noticed that 1 E2E test is failing. Could you please help to check and fix it?

We are good to merge this once we fix the failing e2e test.

Thanks
cc: @jeffpaul

@jeffpaul jeffpaul requested a review from Sidsector9 June 16, 2023 16:00
@jeffpaul jeffpaul modified the milestones: 1.2.1, 1.2.0 Jun 16, 2023
@Sidsector9 Sidsector9 merged commit f79d093 into develop Jun 20, 2023
@Sidsector9 Sidsector9 deleted the feature/setup-cypress-for-e2e-testing branch June 20, 2023 11:46
@jeffpaul jeffpaul mentioned this pull request Jun 22, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Cypress for E2E testing
4 participants