Adjust enable_block_editor to prevent removal of block editor support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sidsector9
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Thanks and congratulations for your first PR in Convert to Blocks @stormrockwell
The code looks good and tests well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Instead of disabling the block editor if a post type doesn't support the gutenbridge, it will respect its current settings. This fixes an issue with this plugin removing Gutenberg support from post types with the block editor enabled.
Issue: #135
How to test the Change
The block editor should still be visible when editing a post.
The classic editor should be visible with the block editor removed.
The block editor should be visible when editing a post.
Changelog Entry
Credits
Not sure but on the issue @jeffpaul and @dsawardekar confirmed this was an issue and agreed with the initial approach I had so thank you!
Checklist: