-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at phpunit tests #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `npm run build`.
Update README.md
dsawardekar
changed the title
Feature/first pass at phpunit tests
First pass at phpunit tests
Sep 30, 2020
Hey @dsawardekar we changed the plugin name to "Convert to Blocks. Can you refactor the PR please? |
jeffpaul
requested changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to "Convert to Blocks" naming
…/gutenbridge into feature/first-pass-at-phpunit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
First attempt at unit tests for the PHP code.
Description of the Change
This PR includes tests for,
Alternate Designs
NA
Benefits
Improved maintainability and test coverage.
Possible Drawbacks
NA
Verification Process
vendor/bin/phpunit
Checklist:
Applicable Issues
NA
Changelog Entry
Added initial PHPUnit Tests.