Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #69

Merged
merged 2 commits into from
May 25, 2022
Merged

Fix unit tests #69

merged 2 commits into from
May 25, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 25, 2022 •
edited
Loading

Description of the Change

Added https://github.com/Yoast/PHPUnit-Polyfills to fix PHPUnit tests

Closes #68

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - PHPUnit tests

Credits

Props @cadic

@cadic cadic requested review from a team and iamdharmesh and removed request for a team May 25, 2022 10:27
@cadic cadic marked this pull request as ready for review May 25, 2022 10:27
@cadic cadic self-assigned this May 25, 2022
@cadic cadic added this to the 1.1.0 milestone May 25, 2022
@cadic cadic mentioned this pull request May 25, 2022
Merged
9 tasks
iamdharmesh
iamdharmesh approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffpaul jeffpaul merged commit da2aff8 into develop May 25, 2022
@jeffpaul jeffpaul deleted the fix/unit-tests branch May 25, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Unit tests are broken
3 participants
@cadic @iamdharmesh @jeffpaul