Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add eslint and phpcs actions #8

Merged
merged 2 commits into from
Oct 7, 2020
Merged

CI: add eslint and phpcs actions #8

merged 2 commits into from
Oct 7, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Add GitHub Actions for eslint and phpcs.

Alternate Designs

n/a

Benefits

These actions create inline annotations with issues. They provide better feedback and help us spot lint issues much easier.

Possible Drawbacks

None that I'm aware of.

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul added this to the 1.2.0 milestone Oct 7, 2020
@jeffpaul jeffpaul merged commit 1c5cf13 into develop Oct 7, 2020
@jeffpaul jeffpaul modified the milestones: 1.0.1, 1.0.0 Jan 14, 2021
@jeffpaul jeffpaul deleted the add/github-actions-lint branch February 8, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dinhtungdu dinhtungdu

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dinhtungdu @jeffpaul