Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clearThenType #18

Closed
Tracked by #7
dinhtungdu opened this issue Mar 23, 2022 · 3 comments
Closed
Tracked by #7

clearThenType #18

dinhtungdu opened this issue Mar 23, 2022 · 3 comments
Assignees
@iamdharmesh
Labels
resolution:wontfix We do not intend to resolve this issue.

Comments

@dinhtungdu
Copy link
Contributor

No description provided.

@dinhtungdu dinhtungdu mentioned this issue Mar 23, 2022
Closed
8 tasks
@iamdharmesh iamdharmesh self-assigned this Mar 28, 2022
@iamdharmesh
Copy link
Member

Hi @dinhtungdu @cadic,

Considering Cypress Best Practices here, I am not sure if we should add this command to this lib or not.
cy.get().clear().type() vs cy.get().clearThenType()

This is a great command to add for specific plugin tests, but I don't think it is good to add in this lib. what do you think?

Thanks.

@iamdharmesh iamdharmesh moved this to Incoming in Open Source Practice Mar 28, 2022
@iamdharmesh iamdharmesh moved this from Incoming to In Progress in Open Source Practice Mar 28, 2022
@dinhtungdu
Copy link
Contributor Author

I agree! I actually prefer cy.get().clear().type() over the other.

@cadic cadic added the resolution:wontfix We do not intend to resolve this issue. label Mar 29, 2022
@cadic
Copy link
Contributor

cadic commented Mar 29, 2022

I agree that this command is overcomplicating things. Closing this.

@cadic cadic closed this as completed Mar 29, 2022
Repository owner moved this from In Progress to Merged in Open Source Practice Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamdharmesh iamdharmesh

Labels
resolution:wontfix We do not intend to resolve this issue.
Projects
Open Source Practice
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cadic @dinhtungdu @iamdharmesh