Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate custom commands from 10up/ElasticPress #7

Closed
8 tasks done
Tracked by #4
dinhtungdu opened this issue Mar 8, 2022 · 7 comments
Closed
8 tasks done
Tracked by #4

Migrate custom commands from 10up/ElasticPress #7

dinhtungdu opened this issue Mar 8, 2022 · 7 comments
Assignees
Labels
resolution:resolved This issue has been resolved.

Comments

@dinhtungdu
Copy link
Contributor

dinhtungdu commented Mar 8, 2022

@dinhtungdu dinhtungdu changed the title MIgrate custom commands from 10up/ElasticPress Migrate custom commands from 10up/ElasticPress Mar 8, 2022
@felipeelia
Copy link
Member

felipeelia commented Mar 14, 2022

HI there! These are the commands we've created for ElasticPress (here):

  • login
  • visitAdminPage
  • createTaxonomy
  • openDocumentSettingsSidebar
  • openDocumentSettingsPanel
  • clearThenType
  • wpCli
  • wpCliEval
  • publishPost
  • activatePlugin
  • deactivatePlugin
  • updateFeatures (EP related)
  • updateWeighting (EP related)
  • maybeEnableFeature (EP related)
  • maybeDisableFeature (EP related)
  • getTotal (EP related)

Which ones do you think would be interesting to make available in this lib?

My highlights from the list would be:

  1. clearThenType: Cypress's type only adds new strings, this command clear the input before adding anything
  2. wpCliEval: A handy way to create options in WordPress that need to be serialized before saved, like arrays.

@dinhtungdu
Copy link
Contributor Author

openDocumentSettingsSidebar
openDocumentSettingsPanel
clearThenType
wpCli
wpCliEval
publishPost
activatePlugin
deactivatePlugin

I think these ones are great to be migrated.

@cadic
Copy link
Contributor

cadic commented Mar 17, 2022

@felipeelia @dinhtungdu please note, I am already working on Document Settings Sidebar and Panel migration from Simple Podcasting within #5

I am making openDocumentSettingsSidebar support of tab name to be compatible to both Post, Page or Block tabs (Existing command from both ElasticPress and SimplePodcasting is hardcoded to be Post-tab only compatible)

@cadic
Copy link
Contributor

cadic commented Mar 22, 2022

I've updated the issue description with the checklist of desired commands

@cadic
Copy link
Contributor

cadic commented Mar 22, 2022

@felipeelia @dinhtungdu taking over plugin activation/deactivation commands (with support of "current plugin" by default)

@dinhtungdu
Copy link
Contributor Author

@cadic I create issues for each command. Feel free to close more than one issue in a PR : )!

@vikrampm1 vikrampm1 moved this to Incoming in Open Source Practice Mar 23, 2022
@vikrampm1 vikrampm1 moved this from Incoming to In Progress in Open Source Practice Mar 23, 2022
@cadic cadic added the resolution:resolved This issue has been resolved. label Mar 29, 2022
@cadic
Copy link
Contributor

cadic commented Jun 9, 2022

Closing this since all sub-tasks are completed

@cadic cadic closed this as completed Jun 9, 2022
Repository owner moved this from In Progress to Merged in Open Source Practice Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:resolved This issue has been resolved.
Projects
Archived in project
Development

No branches or pull requests

3 participants