Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore permalink structure to default after tests. #120

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Feb 14, 2024

Description of the Change

Modifies the permalink structure test's after() routine to match the permalink structure defined during initialization. This is to ensure the permalink tests to not break other tests expecting the default permalink structure.

npm run env run tests-cli "wp rewrite structure '/%postname%/' --hard"

Closes #119.

How to test the Change

  1. Run CYPRESS_WORDPRESS_CORE=x.x npm run cypress:open where x.x is the version of WordPress you a testing with.
  2. Run the check-sitemap-exists tests, these should pass
  3. Run the set-permalink-structure tests, these should pass
  4. Re-run the check-sitemap-exists tests, these should pass (on the develop branch this second run will fail)

Changelog Entry

Fixed - Permalink tests clean up routine.

Credits

Props @peterwilsoncc

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@peterwilsoncc peterwilsoncc requested a review from a team as a code owner February 14, 2024 22:43
@peterwilsoncc peterwilsoncc requested review from iamdharmesh and removed request for a team February 14, 2024 22:43
@jeffpaul jeffpaul added this to the 0.3.0 milestone Feb 15, 2024
@dkotter dkotter merged commit ef4077e into develop Apr 4, 2024
6 of 8 checks passed
@dkotter dkotter deleted the fix/119-permalink-test-cleanup branch April 4, 2024 16:19
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
…test-cleanup

Restore permalink structure to default after tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Tests: Permalink test breaks Sitemap test on subsequent runs
3 participants