Ensure that the insertBlock command works properly in all cases.
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
faisal-alvi
reviewed
Jul 2, 2024
There was a problem hiding this comment.
@iamdharmesh I noticed the E2E failure on this PR for WP trunk. Should we look into it?
|
Yes @faisal-alvi. That is due to changes in WP 6.6. I will check on it and fix it. That's why I converted PR to Draft to hold a review on PR. Thanks. |
|
@faisal-alvi This is ready for review now. |
4 tasks
faisal-alvi
approved these changes
Jul 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
Ensure that the `insertBlock` command works properly in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR removes the
expectcheck from the insert block command. Currently, after inserting a block, we check that there is one block in the editor. However, this fails in cases where we need to add more than one block or when the editor already has blocks present and we add another block. In such cases, the block count becomes more than one, and the tests eventually fail. This PR makes changes to remove theexpectassertion and respond with the ID from the last block.How to test the Change
Make sure the
insertBlockcommand's E2E tests are passing.Changelog Entry
Credits
Props @iamdharmesh
Checklist: