Set Permalink Structure command #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dinhtungdu
reviewed
Mar 23, 2022
Comment on lines
+14
to
+16
| if ('' !== type) { | ||
| cy.get('#permalink_structure').click().type(type); | ||
| } |
There was a problem hiding this comment.
@cadic Should we check for this earlier? If users pass the empty type, we do nothing.
Or if the type is required, let's remove the default value!
Setting the default to /%postname%/ is another good direction IMO.
There was a problem hiding this comment.
Empty string is for "Plain" structure. Setting /%postname%/ as default will break the logic, because Plain is default in WordPress core. I will remove the default value.
The "clear before type" workaround is required because Cypress doesn't allow to type empty string.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
…nk-structure Set Permalink Structure command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds
setPermalinkStructurecommandChecklist:
Changelog Entry
Credits
Props @