Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openDocumentSettings* commands in case Classic Editor is installed #27

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Fix openDocumentSettings* commands in case Classic Editor is installed #27

merged 1 commit into from
Mar 25, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Mar 23, 2022 •
edited
Loading

Description of the Change

Both of openDocumentSettingsPanel and openDocumentSettingsSidebar commands does not check if Block Editor is enabled on the page. This fix updates tests for both (combined into single suite): we enable Block Editor back before testing if Classic Editor is enabled.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@cadic cadic changed the title Install Classic Editor and fix test Fix openDocumentSettings* commands in case Classic Editor is installed Mar 23, 2022
@cadic cadic self-assigned this Mar 23, 2022
@cadic cadic requested a review from dinhtungdu March 23, 2022 13:56
@cadic cadic mentioned this pull request Mar 24, 2022
Merged
6 tasks
dinhtungdu
dinhtungdu approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dinhtungdu dinhtungdu merged commit ba70187 into trunk Mar 25, 2022
@dinhtungdu dinhtungdu deleted the fix/block-tests-fail branch March 25, 2022 11:55
github-actions bot pushed a commit that referenced this pull request Mar 25, 2022
@dinhtungdu
Build: (ba70187) Merge pull request #27 from 10up/fix/block-tests-fail
9cb93a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadic @dinhtungdu