Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close Welcome Guide #42

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Close Welcome Guide #42

merged 2 commits into from
Mar 31, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Mar 30, 2022

Description of the Change

Adds new command closeWelcomeGuide. Tested against every major release since 5.2.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@cadic cadic added type:enhancement New feature or request. new:command When new command is requested. labels Mar 30, 2022
@cadic cadic requested review from dinhtungdu and iamdharmesh March 30, 2022 16:19
@cadic cadic self-assigned this Mar 30, 2022
iamdharmesh
iamdharmesh approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cadic. LGTM!! 👍

@cadic cadic merged commit 741f226 into trunk Mar 31, 2022
@cadic cadic deleted the command/close-welcome-guide branch March 31, 2022 08:51
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
@cadic
Build: (741f226) Merge pull request #42 from 10up/command/close-welco…
8ee7ac9 
…me-guide

Close Welcome Guide
@cadic cadic mentioned this pull request Mar 31, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

@dinhtungdu dinhtungdu Awaiting requested review from dinhtungdu

Assignees

@cadic cadic

Labels
new:command When new command is requested. type:enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadic @iamdharmesh