Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createTerm tests #45

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Fix createTerm tests #45

merged 3 commits into from
Apr 1, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Mar 31, 2022 •
edited
Loading

Description of the Change

This PR adds improvements and fixes failed createTerm:

  • Using random names for categories and tags
  • Using async expectations instead of cy.wait()

Closes #44

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@cadic cadic self-assigned this Mar 31, 2022
@cadic cadic requested a review from iamdharmesh April 1, 2022 13:40
iamdharmesh
iamdharmesh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @cadic. LGTM!! 👍

@iamdharmesh iamdharmesh merged commit 1c47288 into trunk Apr 1, 2022
@iamdharmesh iamdharmesh deleted the fix/44 branch April 1, 2022 14:32
github-actions bot pushed a commit that referenced this pull request Apr 1, 2022
@iamdharmesh
Build: (1c47288) Merge pull request #45 from 10up/fix/44
70938a0 
Fix createTerm tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createTerm test fails in master WordPress version
2 participants
@cadic @iamdharmesh