Migrate to Cypress 10 #74
Conversation
iamdharmesh
requested review from
a team and
peterwilsoncc
and removed request for
a team
| @@ -16,8 +16,8 @@ | |||
| "prepare": "husky install", | |||
| "prettify": "prettier --write \"**/*.{ts,js}\"", | |||
| "typecheck": "tsc --noEmit", | |||
| "cypress:open": "cypress open --config-file tests/cypress/config.json", | |||
| "cypress:run": "cypress run --config-file tests/cypress/config.json", | |||
| "cypress:open": "cypress open --config-file tests/cypress/cypress-config.js --e2e --browser chrome", | |||
There was a problem hiding this comment.
Is it possible to use a custom script that allows the --browser parameter to be overridden when running the script?
There was a problem hiding this comment.
@peterwilsoncc The --browser parameter was added here to the auto-select browser during the test, otherwise, we have to select the browser from UI during the run test in open mode.
Also, we can use a script like this npm run cypress:open -- --browser=firefox to select the Firefox browser or npm run cypress:open -- --browser=electron for Electron.
Should I remove the --browser parameter?
| cy.get('body').then($body => { | ||
| let name = 'Status & visibility'; | ||
| if ( | ||
| $body.find( | ||
| '.components-panel__body .components-panel__body-title button:contains("Summary")' | ||
| ).length > 0 | ||
| ) { | ||
| name = 'Summary'; | ||
| } | ||
| cy.openDocumentSettingsPanel(name); | ||
| }); |
There was a problem hiding this comment.
The selector for the component hasn't changed, ie it is .components-panel .edit-post-post-status in both 6.0 and 6.1. Is it possible to use that instead?
Otherwise, maybe see if it's possible to catch the change in openDocumentSettingsPanel to maintain backward compatibility for other repos using the function. @cadic may have some thoughts here.
There was a problem hiding this comment.
@peterwilsoncc the cy.openDocumentSettingsPanel() command is using the title as identifier of the panel because in general most of panels doesn't have a unique class :(
There was a problem hiding this comment.
Yes, I think it is better to catch the change in openDocumentSettingsPanel to get this maintained among other repos as well. what do you think @cadic @Sidsector9?
There was a problem hiding this comment.
@iamdharmesh could you please resolve conflicts?
Nevermind, did that myself
* Upgrade NPM packages. * Upgrade config file. * Renamed test folder * Removed plugins * upgrade support file * Update npm scripts. * Test folder path update. * downgrade typedoc package to keep doc site as it is. * Stop video to check if it can make e2e tests fast. * Fix test failing in 6.1 * Add dependencies back * Fix tests. Co-authored-by: Max Lyuchin <maxim.lyuchin@gmail.com>
Description of the Change
This PR upgrades the Cypress version to 10 and updates needed files as part of the migration.
Closes #67
How to test the Change
Make sure PR
PASSE2E tests check OR verify E2E tests locally.Changelog Entry
Credits
Props @iamdharmesh @cadic
Checklist: