Update target branch for workflows #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
a team and
iamdharmesh
and removed request for
jeffpaul and
a team
iamdharmesh
reviewed
Mar 9, 2023
.github/workflows/docs.yml
Outdated
| @@ -3,7 +3,7 @@ name: Build and Deploy Documentation | |||
| on: | |||
| # Triggers the workflow on push or pull request events but only for the trunk branch | |||
| push: | |||
| branches: [ trunk ] | |||
| branches: [ trunk, develop ] | |||
There was a problem hiding this comment.
@cadic We may still want to generate docs only on push to the trunk brach, not for push to develop branch, right?
There was a problem hiding this comment.
@iamdharmesh thanks for noticing that, of course we should only generate docs for the trunk only (I believe this could be even changed to "publish a release" event). What do you think?
There was a problem hiding this comment.
Yes @cadic, "publish a release" is more appropriate here.
iamdharmesh
approved these changes
Mar 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
…nch-update Update target branch for workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We are changing the target branch from
trunktodevelopfor workflowsChecklist: