Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of dynamic property warning #1230

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Fix creation of dynamic property warning #1230

merged 8 commits into from
Aug 21, 2024

Conversation

kirtangajjar
Copy link
Member

@kirtangajjar kirtangajjar commented Jun 16, 2024 •
edited by peterwilsoncc
Loading

Description of the Change

Fix creation of dynamic property warning

Closes #1229

How to test the Change

  1. Create a site with PHP 8.2+
  2. Create an external connection
  3. Ensure that the warnings in debug logs are no longer shown

Changelog Entry

Fixed - Fix creation of dynamic property warning

Credits

Props @kirtangajjar, @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@kirtangajjar kirtangajjar requested a review from a team as a code owner June 16, 2024 13:03
@kirtangajjar kirtangajjar requested review from iamdharmesh and removed request for a team June 16, 2024 13:03
@github-actions github-actions bot added this to the 2.1.0 milestone Jun 16, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 16, 2024
@vikrampm1 vikrampm1 removed the request for review from peterwilsoncc July 3, 2024 21:07
peterwilsoncc
peterwilsoncc reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kirtan,

As the different authetication classes use different properties, I think it might be best to define these in WordPressBasicAuth to avoid the potential for confusion with the WP.Com oAuth class.

Sidsector9
Sidsector9 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes @peterwilsoncc suggested. Tested and works as expected 👍

@Sidsector9 Sidsector9 merged commit 45045bb into develop Aug 21, 2024
13 of 18 checks passed
@Sidsector9 Sidsector9 deleted the fix/dyn-property-deprecation branch August 21, 2024 10:54
@dkotter dkotter modified the milestones: 2.1.0, 2.0.6 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

@iamdharmesh iamdharmesh Awaiting requested review from iamdharmesh iamdharmesh is a code owner automatically assigned from 10up/open-source-practice

Assignees

@kirtangajjar kirtangajjar

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.0.6
5 participants
@kirtangajjar @peterwilsoncc @Sidsector9 @dkotter @iamdharmesh