Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 39 move settings to toolbar #103

Merged

Conversation

pabamato
Copy link
Contributor

@pabamato pabamato commented Oct 5, 2021

Description of the Change

Move Special Characters from dropdown menu to a block format menu button:

image

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

  • Edit block content and you will see the Special character's icon within the block format toolbar

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Changed

  • Move icon from dropdown to block format toolbar

@pabamato pabamato linked an issue Oct 5, 2021 that may be closed by this pull request
2 tasks
@jeffpaul jeffpaul requested review from a team and Sidsector9 and removed request for a team October 5, 2021 13:19
@jeffpaul jeffpaul added this to the 1.1.0 milestone Oct 5, 2021
@jeffpaul
Copy link
Member

jeffpaul commented Oct 5, 2021

Where feasible, probably best to move after the bold/italics/link buttons as this is not assume to be the primary button action in this group.

@pabamato
Copy link
Contributor Author

pabamato commented Oct 8, 2021

Where feasible, probably best to move after the bold/italics/link buttons as this is not assume to be the primary button action in this group.

@jeffpaul totally agree with you, button has been moved after core format ones, see: 9647c65
The toolbar now looks like the following:
image

If the goal is to include the Insert special characters format button within the same core toolbar (after link and before chevron down icon), I believe we should go for a different strategy and extend blocks settings using a HOC approach.

@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.4 Oct 8, 2021
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and also sorry for the late review. I tested it and looks good to me. 👍

@jeffpaul jeffpaul merged commit 483058e into 10up:develop Nov 2, 2021
@jeffpaul jeffpaul linked an issue Nov 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not hide RichTextToolbarButton while editing Place Special Characters within block toolbar, not dropdown
3 participants