-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 39 move settings to toolbar #103
Feature/issue 39 move settings to toolbar #103
Conversation
Where feasible, probably best to move after the bold/italics/link buttons as this is not assume to be the primary button action in this group. |
@jeffpaul totally agree with you, button has been moved after core format ones, see: 9647c65 If the goal is to include the Insert special characters format button within the same core toolbar (after link and before chevron down icon), I believe we should go for a different strategy and extend blocks settings using a HOC approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and also sorry for the late review. I tested it and looks good to me. 👍
Description of the Change
Move Special Characters from dropdown menu to a block format menu button:
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
Changelog Entry
Changed