tool/117: add Cypress tests #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
a team and
iamdharmesh
and removed request for
a team
iamdharmesh
reviewed
Mar 24, 2022
.github/workflows/cypress.yml
Outdated
Comment on lines
37
to
38
| - name: Set permissions | ||
| run: ./tests/bin/initialize.sh |
There was a problem hiding this comment.
As we have postenv:start script, I believe this is already running after env:start.
iamdharmesh
reviewed
Mar 24, 2022
There was a problem hiding this comment.
@Sidsector9 Thanks for the great work here. just added minor comments to check.
composer.json
Outdated
Comment on lines
16
to
18
| "scripts": { | ||
| "test:acceptance": "wpacceptance run" | ||
| } |
There was a problem hiding this comment.
We may remove this as well.
iamdharmesh
previously approved these changes
Mar 28, 2022
6 tasks
|
@Sidsector9 looks like a merge conflict, if you can help resolve then we can get this merged in, thanks! |
|
@jeffpaul the tests have started failing for WP trunk for some reason. I'll address it first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #117
Checklist:
Changelog Entry
Credits
Props @Sidsector9 @iamdharmesh