Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump our minimum supported version of WordPress to 5.5 #150

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jun 27, 2022

Description of the Change

While prepping for the 1.0.5 release I realized our E2E tests were failing on WP 5.4, which was our minimum supported version. This was due to changes introduced in #130 that rely on a certain HTML structure. In discussion there, it was determined to bump our minimum version up to where those changes were introduced in WP, which is 5.5.

Alternate Designs

Could fix the JS introduced in #130 to work on 5.4

Possible Drawbacks

Any user's running on WP 5.4 won't be able to update

Verification Process

Verify the WP Minimum E2E test passes (the other two are failing due to timeouts, which seems to have been the case for a bit)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed - Bump our minimum supported WordPress version to 5.5

Credits

Props @dkotter, @jeffpaul, @peterwilsoncc

@dkotter dkotter added this to the 1.0.5 milestone Jun 27, 2022
@dkotter dkotter self-assigned this Jun 27, 2022
@dkotter dkotter requested a review from peterwilsoncc June 27, 2022 22:40
@peterwilsoncc
Copy link
Contributor

I've pushed aec08e5 to fix some linting errors.

Some of the E2E jobs are failing on the front end assertion cy.contains( 'Hello world∀' ); but I am unable to figure out why as Docker broke itself during a recent update.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, approving and merging as the tests are broken on the main branch.

@peterwilsoncc peterwilsoncc merged commit b3ca8b0 into develop Jun 28, 2022
@peterwilsoncc peterwilsoncc deleted the bump-min-wp branch June 28, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants