-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upkeep/170: bump WordPress tested up to from 6.0 to 6.1 #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sidsector9 I have checked it in the WP v6.1 and the popup is going out of the viewport. However, when tested in WP v5.9, it is working fine. Please check the video.
insert-char-pr-173-not-working.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sidsector9 I have checked again in WP v6.1.1 and the popup is still overlapping but the right side and cut in half. Please check the video.
insert-char-pr-173-not-working.mp4
I'm ready to connect 1:1 to test and discuss this in detail.
55e3b08
to
19397c9
Compare
@faisal-alvi that is a known issue with Popover. I have tried to make it work as much as possible, can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Sidsector9. I faced one strange error on WP 6.1, when we clear a Most Used palette and try to insert a special character, it didn't add a character and shows the following error in the console. this is happening with 6.1 only. working fine on WP 6.0.
Uncaught TypeError: Cannot read properties of undefined (reading 'count')
at a.value (index.js?ver=45a2f9e69c15e444b912:1:5708)
at a.value (index.js?ver=45a2f9e69c15e444b912:1:5059)
at onClick (index.js?ver=45a2f9e69c15e444b912:1:7721)
at HTMLUnknownElement.callCallback (react-dom.js?ver=17.0.1:3942:16)
at Object.invokeGuardedCallbackDev (react-dom.js?ver=17.0.1:3991:18)
at invokeGuardedCallback (react-dom.js?ver=17.0.1:4053:33)
at invokeGuardedCallbackAndCatchFirstError (react-dom.js?ver=17.0.1:4067:27)
at executeDispatch (react-dom.js?ver=17.0.1:8273:5)
at processDispatchQueueItemsInOrder (react-dom.js?ver=17.0.1:8305:9)
at processDispatchQueue (react-dom.js?ver=17.0.1:8318:7)
Could you please help to check it once?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the issue @Sidsector9, it looks good now.
Just wanted to add 2 notes here, otherwise, all is good and approved from my side.
@Sidsector9 if you want to resolve the merge conflict here, we're good to otherwise merge this PR |
@jeffpaul dependency review still fails because the license in Wondering if we should add Apache-2.0 AND Apache-2.0 WITH LLVM-exception to the allow-list? |
Yeah, I'll go ahead and merge this in now and amend the license policy next |
Description of the Change
Tested the following manually:
Closes #170
Changelog Entry
Credits
Props @Sidsector9
Checklist: