Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/wp-deploy: Move from actions/upload-release-asset to softprops/action-gh-release #262

Merged
merged 3 commits into from
Aug 14, 2024
Merged

upkeep/wp-deploy: Move from actions/upload-release-asset to softprops/action-gh-release #262

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c591d1d
Merge branch 'develop' of github.com:10up/insert-special-characters i…
Sidsector9 Jul 19, 2024
4170c90
move from actions/upload-release-asset to softprops/action-gh-release
Sidsector9 Jul 19, 2024
fa7e4a5
Merge branch 'develop' into upkeep/wp-deploy
Sidsector9 Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/push-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,8 @@ jobs:
SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}
SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
- name: Upload release asset
uses: actions/upload-release-asset@v1
uses: softprops/action-gh-release@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizing I just approved/merged in some other repos, but curious if we need to similarly update other actions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul we don't need to update the actions you mentioned as this change is only for the asset we attach to the release. The plugin build zip and asset deploy actions are unrelated.

Though we need to update the examples here:

https://github.com/10up/action-wordpress-plugin-deploy/blob/9273e6df8583dadbfd50001908c11c30009a7db4/examples/deploy-on-publishing-a-new-release-and-attach-a-zip-file-to-the-release.yml#L82-L100

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 mind pushing a fix for the action examples then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a PR here - 10up/action-wordpress-plugin-deploy#150

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: ${{ steps.deploy.outputs.zip-path }}
asset_name: ${{ github.event.repository.name }}.zip
asset_content_type: application/zip
files: ${{ github.workspace }}/${{ github.event.repository.name }}.zip
Loading