Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Popover initial focus #96

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix Popover initial focus #96

merged 1 commit into from
Jul 22, 2021

Conversation

phpbits
Copy link
Contributor

@phpbits phpbits commented Jul 15, 2021 •
edited
Loading

Description of the Change

This PR fixes the popover initial focus when it is opened. See image below of the issue.

40b9a53bf9b0c8ca220f9958525fdfa6

Verification Process

Activate Twenty Twenty One theme. Make sure that the popover is displaying from the top instead of bottom or center of the contents.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul requested a review from dinhtungdu July 15, 2021 18:57
@jeffpaul jeffpaul added this to the 1.0.3 milestone Jul 15, 2021
@phpbits phpbits requested a review from jeffpaul July 15, 2021 22:16
@jeffpaul jeffpaul mentioned this pull request Jul 16, 2021
Merged
6 tasks
dinhtungdu
dinhtungdu approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much needed! Thanks, @phpbits! LGTM!

@jeffpaul jeffpaul merged commit 4ef3295 into release/1.0.3 Jul 22, 2021
@jeffpaul jeffpaul deleted the fix/missing-format-button branch July 22, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@phpbits @dinhtungdu @jeffpaul