Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check to ensure we have a valid PHP version before loading plugin functionality and output an admin notice if needed #103

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

kmgalanakis
Copy link
Contributor

@kmgalanakis kmgalanakis commented Aug 18, 2023

Description of the Change

In this PR, I'm adding a check for the minimum required PHP version before attempting to load the plugin files. If the condition is not met an admin notice is displayed and the plugin files are not loaded.

Closes #99

How to test the Change

  • To see the admin notice and have the plugin functionality not loaded, try to load the plugin on a site with PHP version lower that 7.4.

Changelog Entry

Added - Check for minimum required PHP version before loading the plugin

Credits

Props @kmgalanakis

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@kmgalanakis kmgalanakis requested a review from a team as a code owner August 18, 2023 04:35
@kmgalanakis kmgalanakis requested review from Sidsector9 and removed request for a team August 18, 2023 04:35
@kmgalanakis kmgalanakis self-assigned this Aug 18, 2023
@kmgalanakis kmgalanakis added this to the 1.3.1 milestone Aug 18, 2023
retro-webamp-block.php Outdated Show resolved Hide resolved
…in functionality and output an admin notice if needed
@kmgalanakis kmgalanakis force-pushed the feature/add-php-checks branch from 98c729b to 7fc8316 Compare August 18, 2023 05:19
@kmgalanakis kmgalanakis requested a review from ravinderk August 18, 2023 05:24
@Sidsector9 Sidsector9 merged commit 64a1e66 into develop Aug 31, 2023
@Sidsector9 Sidsector9 deleted the feature/add-php-checks branch August 31, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP checks
3 participants