Address deprecation warning for wpmu_new_blog #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpmu_new_blog has been deprecated since 5.1.0, in favor of wp_initialize_site which receives a full WP_Site instance instead of the Blog ID. This approach of checking the version matches how wordpress-seo handles this: https://github.com/Yoast/wordpress-seo/blob/9946d8cdc97857fa8311be2ab0b11cce539beb98/wp-seo-main.php#L442-L449 but depending on this plugin's support matrix, the function could alternatively be switched over to use only the new hook.
faisal-alvi
requested changes
Oct 10, 2022
|
@kadamwhite thanks for your work! I have made minor spacing fixes and a fatal error of a missing bracket. Then tested and it's working fine. 🎉 The object result while testing:
|
faisal-alvi
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adapt plugin to use
wp_initialize_siteinstead of deprecatedwpmu_new_bloghook when using a recent WordPress version.wpmu_new_bloghas been deprecated since 5.1.0, in favor ofwp_initialize_sitewhich receives a full WP_Site instance instead of the Blog ID.This approach of checking the version matches how
wordpress-seohandles this, but depending on this plugin's support matrix, the function could alternatively be switched over to use only the new hook.How to test the Change
I have not exhaustively tested this locally. To test, create a new network site and verify whether the
simple_local_avatarsoption has the expected defaults.Changelog Entry
Checklist: