Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin tested with WP 5.3 #36

Merged
merged 4 commits into from
Jan 7, 2020
Merged

Plugin tested with WP 5.3 #36

merged 4 commits into from
Jan 7, 2020

Conversation

Waka867
Copy link
Contributor

@Waka867 Waka867 commented Dec 16, 2019

Description of the Change

No code changes made. Plugin readme.txt updated to "Tested up to WP 5.3"

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Installed plugin
Plugin loads properly when activated
Profile Image uploads properly
Image is properly saved in uploads with full and five other image sizes
Image maturity rating saves and updates properly
No console errors
Avatar properly obeys max maturity rating set in Settings>Discussion
Avatar takes over profile image when image is appropriate according to maturity levels
Gravatar properly takes over if you have one and no local avatar is set
Only allow local avatars checkbox works properly
Checkbox to only allow users with file upload capabilities to upload local avatars is working properly
Avatar area resizes properly
Updated tested up to in readme.txt to 5.3

Checklist:

  • [ X] I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

… avatars on wp 5.3

Installed plugin
Plugin loads properly when activated
Profile Image uploads properly
Image is properly saved in uploads with full and five other image sizes
Image maturity rating saves and updates properly
No console errors
Avatar properly obeys max maturity rating set in Settings>Discussion
Avatar takes over profile image when image is appropriate according to maturity levels
Gravatar properly takes over if you have one and no local avatar is set
Only allow local avatars checkbox works properly
Checkbox to only allow users with file upload capabilities to upload local avatars is working properly
Avatar area resizes properly
Updated tested up to in readme.txt to 5.3
Updating "Tested up to" to WP 5.3
@Waka867 Waka867 mentioned this pull request Dec 16, 2019
5 tasks
@jeffpaul
Copy link
Member

Resolves #35

@jeffpaul jeffpaul added this to the 2.2 milestone Dec 19, 2019
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Dec 19, 2019
@jeffpaul jeffpaul self-requested a review December 19, 2019 03:19
@jeffpaul jeffpaul mentioned this pull request Jan 7, 2020
6 tasks
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the testing/confirmation @Waka867, this should now be good to merge!

@jeffpaul jeffpaul merged commit e996064 into 10up:develop Jan 7, 2020
@ghost ghost mentioned this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants