Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add id class to avatar section on profile page #54

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

This PR adds class and id to the setting section on the profile edit page so developers can style the setting section easier.

Alternate Designs

N/A

Benefits

Mentioned above.

Possible Drawbacks

Verification Process

Manual verification.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Related support topic: https://wordpress.org/support/topic/how-to-hide-the-rating-row/

Changelog Entry

@jeffpaul jeffpaul added this to the 2.2.0 milestone Aug 10, 2020
@jeffpaul
Copy link
Member

@dinhtungdu please look to resolve the merge conflicts and then this can move towards merge, thanks!

@dinhtungdu
Copy link
Contributor Author

@jeffpaul I fixed the merge conflicts.

@jeffpaul jeffpaul merged commit 5383ad3 into develop Aug 31, 2020
@jeffpaul jeffpaul deleted the add/edit-profile-id-class branch October 28, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants