Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'arch' option was not taking effect during installation #123

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

lifeiyu071
Copy link
Contributor

The installNode method supports the arch parameter, but the arch parameter is not passed in during modal.tsx installation.

@lifeiyu071
Copy link
Contributor Author

In some cases, users may need to install the 32-bit version of a node, so if this is fixed, does it subsequently show arch in the list of installed nodes?

@1111mp
Copy link
Owner

1111mp commented Oct 10, 2024

Thank you for your code submission 🌹

In some cases, users may need to install the 32-bit version of a node, so if this is fixed, does it subsequently show arch in the list of installed nodes?

There is no plan to support this feature at present. The main reasons are as follows:

  • Additional information needs to be stored on each download (which means a new local file needs to be created to store it)
  • This case should be rare, perhaps the user should know which architecture the corresponding nodejs belongs to

@1111mp 1111mp merged commit 2f37c67 into 1111mp:tauri Oct 10, 2024
@lifeiyu071
Copy link
Contributor Author

Well, at least that small percentage of users has been catered for now. Cool. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants