Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[찬우] proposal-string-matchAll #28

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

chanuuuuu
Copy link
Contributor

No description provided.

1101707 and others added 30 commits March 15, 2023 01:21
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
Co-authored-by: HyukJoo Kwon <76726411+huckjoo@users.noreply.github.com>
@chanuuuuu chanuuuuu changed the title proposal-string-matchAll 번역 완료 [찬우] proposal-string-matchAll May 10, 2023
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chanuuuuu 님 고생 많으셨습니다!!

몇가지 리뷰사항 남겨두었습니다. 리뷰가 늦어져서 죄송합니댜ㅑㅑ

src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
src/ko/proposal-string-matchAll.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@chanuuuuu chanuuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 반영 완료되었습니다.

@chanuuuuu chanuuuuu requested a review from hochan222 June 21, 2023 14:57
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다~! LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants