Add context info and callback to getAttributes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to pull in laguange dynamically
andria-dev
reviewed
May 24, 2021
src/getAttributes.js
Outdated
| if (typeof value === "function") { // Callback must return a string or a number | ||
| value = value(context); // Run the provided callback and store the result | ||
| } | ||
|
|
||
| if (typeof value !== "string" && typeof value !== "number") | ||
| throw new Error( | ||
| `Attribute "${key}" must have a value of type string or number not "${typeof value}".` |
There was a problem hiding this comment.
I like the idea of adding support for callbacks with context. I think we should update the wording of the error message to reflect the allowance of callbacks by saying "…must have, or evaluate to, a value of…"
There was a problem hiding this comment.
That makes sense! Updating to the following:
`Attribute "${key}" must have, or evaluate to, a value of type string or number, not "${typeof value}".`
|
We are absolutely going for it here—appreciate this one, I love it! This will be packaged with 4.1.0 |
This was referenced Jun 28, 2022
zachleat
added a commit
to 11ty/11ty-website
that referenced
this pull request
Jun 28, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to pull in contextual information for the syntax highlighting, and pass it to a defined function to get a dynamic output.