Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in variable name when loading Global Data #337

Closed
buckle2000 opened this issue Dec 8, 2018 · 2 comments
Closed

Error in variable name when loading Global Data #337

buckle2000 opened this issue Dec 8, 2018 · 2 comments
Labels
bug waiting-to-close Issue that is probably resolved, waiting on OP confirmation.
Milestone

Comments

@buckle2000
Copy link

buckle2000 commented Dec 8, 2018

This is related to #231 .

Expected:
The variable name should be the relative path to the global data directory.
If I specify dir.data as ../_data, the variable name for xyz.json is still xyz.

Actually:
If I specify dir.data as ../_data, the variable name is _data.xyz.

Here is the minimal project to reproduce this code: archive.tar.gz

@zachleat zachleat added the bug label Dec 13, 2018
@zachleat
Copy link
Member

#231 was fixed in 0.7.0 by @kleinfreund, can you have another look @buckle2000?

@zachleat zachleat added on-hold waiting-to-close Issue that is probably resolved, waiting on OP confirmation. and removed on-hold labels Jan 11, 2019
zachleat added a commit that referenced this issue Mar 8, 2019
@zachleat
Copy link
Member

zachleat commented Mar 8, 2019

Test confirming this is fixed has been added

test("Parent directory for data", async t => {

@zachleat zachleat closed this as completed Mar 8, 2019
@zachleat zachleat added this to the 0.7.2 milestone Mar 8, 2019
zachleat added a commit that referenced this issue Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug waiting-to-close Issue that is probably resolved, waiting on OP confirmation.
Projects
None yet
Development

No branches or pull requests

2 participants