Support scoped prefixing for :host() and :host-context() pseudo classes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functional pseudo classes
|
This is amazing, thank you! It will ship with WebC v0.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on building a site with webc and ran into a point where I was really wishing that the
:host-context()pseudo-class worked for scoped styles. I saw there were some TODO comments regarding that, so I went ahead and took a stab at getting both:host()and:host-context()working.Let me know if I misinterpreted anything, but this was my understanding of how they should work:
:host(.class) {}->.prefix-class.class {}:host-context(.class) {}->.class .prefix-class {}I added some more test cases to thoroughly cover this new functionality and everything seems like it's looking good, but let me know if anything seems off-base!