Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings fixes #175

Merged
merged 2 commits into from
May 22, 2022
Merged

Settings fixes #175

merged 2 commits into from
May 22, 2022

Conversation

mdbooth
Copy link

@mdbooth mdbooth commented May 16, 2022

Port relevant fixes from #173 to v2_devel.

'config' doesn't exist, and 'job.config' is automatically refreshed when
job is refreshed.
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdbooth
Copy link
Author

mdbooth commented May 16, 2022

@1337-server this branch looks much nicer! Are there any known issues holding up adding a Dockerfile?

@1337-server
Copy link
Owner

@1337-server this branch looks much nicer! Are there any known issues holding up adding a Dockerfile?

It's been a while since I checked it fully but, the docker_udev branch is pretty much just the v2_devel branch with the added Dockerfile. I can't remember any major issues with it, just small annoyances getting it started (the user, group id, etc.)

@1337-server 1337-server merged commit 9ec8271 into 1337-server:v2_devel May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants