Narrow TypeScript spec exclusions to spec directory #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Type Checking, Increase type checking code coverage
zachmargolis
approved these changes
Jan 30, 2024
| @@ -27,7 +27,7 @@ const ExtractKeysWebpackPlugin = require('./extract-keys-webpack-plugin.js'); | |||
| * // 'foo' | |||
| * ``` | |||
| * | |||
| * @param {Record<string, any>} object | |||
| * @param {undefined|Record<string, any>} object | |||
There was a problem hiding this comment.
does marking it as optional like this work here?
Suggested change
| * @param {undefined|Record<string, any>} object | |
| * @param {Record<string, any>=} object |
There was a problem hiding this comment.
It looks like TypeScript would treat that as an optional parameter and then get mad about a required parameter following an optional parameter.
app/javascript/packages/rails-i18n-webpack-plugin/rails-i18n-webpack-plugin.js:35:22 - error TS1016: A required parameter cannot follow an optional parameter.
35 function dig(object, keyPath) {
~~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Limits TypeScript exclusions for spec files to those in the
spec/directory.Why?
app/javascript, so...spec/files should be considered "legacy"app/javascript📜 Testing Plan
Verify that TypeScript type-checking passes: