LG-12127 Create DropOff report #9989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Data Reporting, Adds automated IdV DropOff Report
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Jan 29, 2024
|
Spot-checking the results: https://docs.google.com/spreadsheets/d/1jfGZWxHf5Fy9er7jsL0PBEjuSJM7jKIOkswciRtfCpA/edit#gid=0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
DropOff Report LG-12127
🛠 Summary of changes
This creates an automated Idv DropOffReport following the pattern of other automated reports we currently have. This report updates the current manual DropOff Report (which is pulled using data that is known to be inaccurate) by using more accurate CloudWatch events.
Example of current DropOff Report: https://docs.google.com/spreadsheets/d/15uqj9Tl5Mveva-zDPjUK29AkgMYIWuvn2xmuC8miKu8/edit#gid=1479836647
Initially, we believed that there were more events that available from the IdentityVerificationReport, and so made this report inherit from that model. However, there are not many shared events, but I left the inheritance in because we can use the query/cloudwatch client. Open to feedback on whether we should just move some code over!