Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capybara to fix Rack 3 deprecation message #9999

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

mitchellhenke
Copy link
Contributor

🛠 Summary of changes

We currently get a deprecation warning due to the Rack 3 upgrade. This PR fixes it by updating capybara.

Rack::Handler is deprecated and replaced by Rackup::Handler

changelog: Internal, Dependencies, Update capybara to fix Rack 3 deprecation message
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! I was just starting to dig in to this too! Thanks!

@mitchellhenke mitchellhenke merged commit d3e5040 into main Jan 29, 2024
2 checks passed
@mitchellhenke mitchellhenke deleted the mitchellhenke/fix-deprecation-capybara branch January 29, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants