don't check for openssl libcrypto by default on Windows #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Conan/tsschecker uses winapi bcrypt for it's hashing functions so it is unnecessary for configure to check for openssl libcrypto on by default Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1Conan/tsschecker uses winapi bcrypt for it's hashing functions on Windows so it is unnecessary for configure to check for openssl libcrypto by default on Windows.
Fixes
Package requirements (libcrypto >= 1.0) were not metConfigure will only check for openssl libcrypto if you specify
--with-libcryptoor it'll still be default if you are using a non-Windows/Mac platform (e.g Linux).
Tested on MSYS2 Mingw64 without openssl installed and was able to fully build tsschecker and dependencies with no trouble whatsoever.