Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why this library does not follow PSR standards? #30

Open
coderNeos opened this issue Sep 18, 2019 · 2 comments
Open

Why this library does not follow PSR standards? #30

coderNeos opened this issue Sep 18, 2019 · 2 comments

Comments

@coderNeos
Copy link

Are there any plans to rewrite this library according to PSR standards?
There are few reasons to do that:

  1. PSR is widely adopted standard in PHP community (all popular frameworks follow PSR)
  2. It will be impossible to configure linter when trying to integrate this library in a codebase, which follows PSR
@pammel
Copy link

pammel commented Feb 7, 2021

I'm sorry, it doesn't inspire much confidence when IMSGlobal wants to define standards on the one hand, but doesn't adhere to standards itself. It has now been more than one year since this problem was reported. Especially PSR-4 would be extremely important (Autoloader).

@MartinLenord
Copy link
Collaborator

Hi @pammel, this library was developed more as a testing and learning tool for the LTI specifications that can be used to try out changes and developments to the LTI specifications, and as such isn't really actively developed for purposes beyond that.

You might find a few better resources on https://github.com/IMSGlobal/ltibootcamp which has links to some other open sourced PHP libraries for LTI 1.3 that may better suit your needs like the one written by Open Assessment Technologies https://github.com/oat-sa/lib-lti1p3-core

I wish i had more time for improving this library, but as i don't work for the IMS or use PHP in my day to day work, i haven't been able to find much time to make those improvements

snake pushed a commit to snake/lti-1-3-php-library that referenced this issue Jan 19, 2022
…ades

PODB-263 Fix 0 grades not syncing for LTI 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants