Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复应用商店详情页面部分图标比例错误 #4168

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix: 修复应用商店详情页面部分图标比例错误 #4168

merged 2 commits into from
Mar 13, 2024

Conversation

A-kirami
Copy link
Contributor

What this PR does / why we need it?

image

部分宽高不等的图标在详情页面显示比例错误

Summary of your change

添加了 object-contain 样式

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Copy link

f2c-ci-robot bot commented Mar 12, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud
Copy link
Member

感谢支持。

@zhengkunwang223
Copy link
Member

测试了一下
image
图标变成这样 是还需要修改哪里吗

@A-kirami
Copy link
Contributor Author

测试了一下 image 图标变成这样 是还需要修改哪里吗

更换成了内联样式

@zhengkunwang223 zhengkunwang223 merged commit b643fa2 into 1Panel-dev:dev Mar 13, 2024
1 check was pending
KaySar12 pushed a commit to KaySar12/1Panel that referenced this pull request Oct 17, 2024
* fix: 修复应用商店详情页面部分图标比例错误

* fix: 替换为内联样式
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants