Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 告警通知 #6184

Merged
merged 2 commits into from
Aug 20, 2024
Merged

feat: 告警通知 #6184

merged 2 commits into from
Aug 20, 2024

Conversation

lan-yonghui
Copy link
Member

No description provided.

Copy link

f2c-ci-robot bot commented Aug 20, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@1Panel-bot 1Panel-bot added the dev label Aug 20, 2024
return db.Where("id in (?)", ids)
}
}

func (w WebsiteSSLRepo) Page(page, size int, opts ...DBOption) (int64, []model.WebsiteSSL, error) {
Copy link
Member

@ssongliu ssongliu Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接用 commonRepo.WithIdsIn

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哎呀 common有呀😂 还写了好几个

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@wanghe-fit2cloud wanghe-fit2cloud merged commit e770254 into dev Aug 20, 2024
3 of 5 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the pr@dev@feat_alert branch August 20, 2024 14:11
KaySar12 pushed a commit to KaySar12/1Panel that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants