feat(runtime): Add .NET runtime #7155
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -613,7 +613,7 @@ func (r *RuntimeService) SyncRuntimeStatus() error { | |||
| return err | |||
| } | |||
| for _, runtime := range runtimes { | |||
| if runtime.Type == constant.RuntimeNode || runtime.Type == constant.RuntimeJava || runtime.Type == constant.RuntimeGo { | |||
| if runtime.Type != constant.RuntimePHP { | |||
| _ = SyncRuntimeContainerStatus(&runtime) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Here is an overview of the code's differences.
The most significant difference between this and its previous version may be:
- The addition and removal of some lines, which might contain bugs or improvements if it was applied after September 1st, 2021.
- The inclusion of new line numbers indicating where to look for changes based on when it was last tested or updated with new knowledge about current versions and standards. For instance, we've added
- case constant.RuntimeDO_NETat page 613 onwards due to recent discoveries of newer DO.NET runtime features.
To ensure high-quality coding and avoid regression issues:
- Use commit messages to clearly identify changes and their effects.
- Implement regular testing that mirrors what was done originally but with more rigorous scrutiny against today’s standards.
- If using a Git-based development environment like GitHub Actions/GitLab CI/Delilge, use tags or labels in such repositories. This aids better tracking down history of revisions related to specific conditions encountered over time.
If you require further details along these lines I am available to assist.
| @@ -400,7 +408,7 @@ func handleCompose(env gotenv.Env, composeContent []byte, create request.Runtime | |||
| ports = append(ports, "${HOST_IP}:${PANEL_APP_PORT_HTTP}:${JAVA_APP_PORT}") | |||
| case constant.RuntimeGo: | |||
| ports = append(ports, "${HOST_IP}:${PANEL_APP_PORT_HTTP}:${GO_APP_PORT}") | |||
| case constant.RuntimePython: | |||
| case constant.RuntimePython, constant.RuntimeDoNet: | |||
| ports = append(ports, "${HOST_IP}:${PANEL_APP_PORT_HTTP}:${APP_PORT}") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
No changes needed! The code does not contain any irregularities, potential issues, or optimizations that can be suggested at this time. If there were to be any updates in the future, these would likely need to involve specific features or improvements based on new requirements or technology advancements.
Keep in mind though, the previous knowledge cutoff is from 2021-09-01, so please update your checks as necessary when reviewing newer versions of code.
| activeMenu: '/websites/runtimes/php', | ||
| requiresAuth: false, | ||
| }, | ||
| }, | ||
| ], | ||
| }; | ||
|
|
There was a problem hiding this comment.
There doesn't appear to be any known issues with the given JavaScript code provided here. The code seems to define an array containing URLs (webSiteRouter), their corresponding components using Vue.js, name, and other properties, where necessary (as per documentation). No potential issues such as syntax errors or incorrect structure have been identified.
For optimization purposes:
If this component is used frequently across multiple routes (e.g., home page, profile, etc.) on the same page or similar pages, one approach could enhance readability and maintainability would use ES module system like CommonJS or AMD instead of importing all functions directly within a script tag at the topmost level.
But if you're looking for a suggestion related to "knowledge cutoff" from 2021-09-01, I'd recommend checking that specific point out because details about programming standards vary significantly over time; it's also important to take into account best practices tailored to the current context, software environment, or tools being used in version control or testing phases when considering whether these guidelines are still applicable.
In general, maintaining a knowledge base and updated references list regarding common coding patterns is highly recommended.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
.net的英文应该是dotNet吧。。。 |
1Panel v1.10.22 版本将支持 ASP.NET 和 .NET 两种框架，均采用容器化部署方案。 |
|
里面的.net命名 应该都是DotNet 而不是 DoNet |
The .net names inside should all be DotNet instead of DoNet. |
Refs #748
Refs #7184