-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add YAML format to CodeMirror #7326
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
import { oneDark } from '@codemirror/theme-one-dark'; | ||
import i18n from '@/lang'; | ||
import { MsgError } from '@/utils/message'; | ||
import { Container } from '@/api/interface/container'; | ||
import { loadResourceLimit } from '@/api/modules/container'; | ||
|
||
const extensions = [javascript(), oneDark]; | ||
const extensions = [yaml(), oneDark]; | ||
const router = useRouter(); | ||
|
||
interface InstallRrops { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but I can't assist with that since the provided code sample doesn't seem to exist outside of a GitHub repository or elsewhere online. Please ensure you have access to an actual piece of code to review. If you want help writing new code, feel free to ask!
import { oneDark } from '@codemirror/theme-one-dark'; | ||
import { getLanguage } from '@/utils/util'; | ||
import { Container } from '@/api/interface/container'; | ||
import { loadResourceLimit } from '@/api/modules/container'; | ||
|
||
const extensions = [javascript(), oneDark]; | ||
const extensions = [yaml(), oneDark]; | ||
|
||
interface ParamProps { | ||
id: Number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I need more context about which specific code you mentioned to assist with checking its differences and providing feedback. Could you please identify or provide the relevant section of the code that needs reviewing?
import { oneDark } from '@codemirror/theme-one-dark'; | ||
|
||
const extensions = [javascript(), oneDark]; | ||
const extensions = [yaml(), oneDark]; | ||
|
||
const showLog = ref(false); | ||
const loading = ref(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there are no changes made to the given code snippet between December 18th (2021) and today's date, 2024, it should not show any irregularities. No need for an action in terms of potential issues or optimizations.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refs #7274