-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Application Startup Failure Caused by Case-Sensitive Applica… #7601
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -173,7 +173,7 @@ const installData = ref<InstallProps>({ | |||
}); | |||
const open = ref(false); | |||
const rules = ref<FormRules>({ | |||
name: [Rules.appName], | |||
name: [Rules.paramSimple], | |||
params: [], | |||
version: [Rules.requiredSelect], | |||
containerName: [Rules.containerName], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference in this code snippet is that the appName
rule from "Rules"
has been replaced with "paramSimple"
. It's unclear what these rules are defined as, but replacing one with another could have different behaviors or constraints depending on their implementation. Ensure both "appName" and "paramSimple" rules behave similarly to avoid unexpected behavior in the application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refs #7600